Add database constraints to enforce unique version numbers #1538
+114
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timobrembeck
force-pushed
the
enhancement/version-unique-constraint
branch
from
1a80449 to
1c34ae3
Compare
|
Code Climate has analyzed commit 1c34ae3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 74.0% (0.0% change). View more on Code Climate. |
ulliholtgrave
approved these changes
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Ensure version numbers are unique for all content objects in each language.
Proposed changes
UniqueConstraints for all content translation modelsResolved issues
My hope is that this is a quick temporary fix for #1518 and #1530 to make sure that at least the database integrity is preserved and an internal server error is thrown instead of creating duplicate translation versions.